This edition of the Core Weekly report highlights changes in PrestaShop’s core codebase from Monday 1st to Sunday 7th of March 2021.
General messages
Dear developers,
We enter the month of March, and this is the last month before April when we expect the feature freeze to happen!
Multiple projects for 1.7.8 have delivered major milestones last week:
Virtual product files are now managed in the new Product Page being built, as well as improvements for handling suppliers for product with combinations.
The Back Office maintenance page is now the first Symfony Back Office page using the new Multistore checkboxes interface to manage multistore settings.
We also would like to applause the merge of PR #20288 which is the Back Office page “Customers > Outstanding” migrated to Symfony by contributor @ks129!
Releases
A quick update about PrestaShop’s GitHub issues and pull requests:
- 68 new issues have been created in the project repositories;
- 71 issues have been closed, including 8 fixed issues on the core;
- 80 pull requests have been opened in the project repositories;
- 114 pull requests have been closed, including 69 merged pull requests.
Code changes in the ‘develop’ branch
Core
- #23451: Update phpstan to 0.12.80, by @matks
- #23443: Fixed save of translation message. Thank you @agostinofiscale
- #23407: Helperlist optimization, by @PierreRambaud
- #21125: Introduce ContextLoadHelper to load legacy context in Commands, by @matks
Back office
- #23510: Fix visibility of const OutstandingGridDefinitionFactory::GRID_ID, by @matks
- #23507: Fix search icon height, by @NeOMakinG
- #23425: Additional checks for var existence in Admin Features controller. Thank you @kpodemski
- #23409: Allow module exception to be displayed to make debugging easier, by @Quetzacoalt91
- #23405: Make sure array are correctly filled in Customer class, by @PierreRambaud
- #23386: Introduce UpdateVirtualProductFileCommand. Thank you @zuk3975
- #23284: Implement SetCombinationSuppliers & RemoveAllCombinationSuppliers commands. Thank you @zuk3975
- #23234: Translations – ThemeExporter : Use array of directories when getting catalog, by @sowbiba
- #23146: Adjust default BO theme styles to new-theme styles, by @NeOMakinG
- #23020: Add consistency to page blocks in the BO, by @NeOMakinG
- #22379: Multistore checkboxes on maintenance configuration pages, by @matthieu-rolland
- #21243: Simplified the Administration form. Thank you @JevgenijVisockij
- #20288: Migrate “Customers > Outstanding”. Thank you @ks129
Front office
- #23473: Make sure key exists before using it, by @PierreRambaud
- #23406: Check if id_country exists before using the result of the array, by @PierreRambaud
Tests
- #23539: Disable temporarily phpstan extension, by @matks
- #23522: Introduce phpstan for prestashop v1.1 with 3 new Rules: ClassConstantsMustHaveVisibilityRule, UseTypeHintForNewMethodsRule, UseTypedReturnForNewMethodsRule, by @matks
- #23494: Fix click on toggles on nightly develop, by @boubkerbribri
- #23490: Use GA ubuntu 18.04 for sanity and integration tests, by @matks
- #23489: Improve integration.yml GA file name, by @matks
- #23463: Rename PHPStan exclude class list, by @matks
Code changes in the ‘1.7.7.x’ branch
Front office
- #23388: Fix product list width on home and search page, by @NeOMakinG
Tests
- #23519: Fix local sort for shop url on multistore, by @boubkerbribri
- #23503: Add test ‘Check links in header page FO’. Thank you @nesrineabdmouleh
- #23471: Backport test ‘Check footer links’. Thank you @nesrineabdmouleh
- #23464: Add test ‘Filter, sort and pagination shop urls’. Thank you @nesrineabdmouleh
- #23452: Add test – Check product block in order page BO. Thank you @nesrineabdmouleh
Code changes in modules, themes & tools
Circuit breaker
- #39: Migrated from Travis CI to Github Actions, by @Progi1984
Wishlist block module
- #103: Fixed call to vendor/autoload.php, by @Progi1984
- #102: Add assets, by @NeOMakinG
- #100: Fix getting cover. Thank you @kpodemski
PrestaShop on Docker
- #19: Improve readme file and remove PHP7.0 , by @PierreRambaud
- #18: Add image for PHP 7.4, by @PierreRambaud
PrestonBot
- #115: Migrated from TravisCI to Github Actions, by @Progi1984
Changes in developer documentation
- #877: Fix module send example directory. Thank you @nenes25
- #876: Fix typo in contribution guidelines, by @matks
Customer reassurance block module
- #142: Bump webpack from 5.24.2 to 5.24.3. Built by @dependabot
- #141: Bump css-loader from 5.1.0 to 5.1.1. Built by @dependabot
- #140: Bump @babel/core from 7.13.1 to 7.13.8. Built by @dependabot
Faceted search module
- #360: Bump chai from 4.3.1 to 4.3.3. Built by @dependabot
- #359: Bump webpack from 5.24.2 to 5.24.3. Built by @dependabot
- #358: Bump chai from 4.3.0 to 4.3.1. Built by @dependabot
- #357: Bump @babel/preset-env from 7.13.8 to 7.13.9. Built by @dependabot
- #356: Bump css-loader from 5.1.0 to 5.1.1. Built by @dependabot
- #355: Bump @babel/preset-env from 7.13.5 to 7.13.8. Built by @dependabot
- #354: Bump @babel/register from 7.13.0 to 7.13.8. Built by @dependabot
- #353: Bump @babel/core from 7.13.1 to 7.13.8. Built by @dependabot
PrestaShop PHPStan extension
- #14: Handle multiple loads of same file through PHPConfigurationFileLoader, by @matks
- #13: Fix extension.neon indentation, by @matks
- #12: Improve documentation for UseTypedReturnForNewMethodsRule, by @matks
- #11: Introduce UseTypeHintForNewMethodsRule, by @matks
- #9: Introduce UseTypedReturnForNewMethodsRule, by @matks
User documentation landing page
- #36: chore(deps-dev): bump eslint from 7.20.0 to 7.21.0. Built by @dependabot
- #35: fix(deps): bump core-js from 3.9.0 to 3.9.1. Built by @dependabot
GDPR module
- #138: Modify GitHub Action PHP CS Fixer to not depend on prestashopcorp, by @matks
- #137: Apply license headers from native modules, by @matks
- #134: Bump prestashop/php-dev-tools from 3.4 to 3.14. Built by @dependabot
PrestaShop Specifications
- #208: Move wishlist specs into the modules repo, by @marionf
- #188: Create specs for ecotax, by @marionf
Prestashop UI Kit
- #138: Fix select2 initialization on storybook, by @NeOMakinG
Decimal
- #15: Migrate to Coveralls & Added support versions, by @Progi1984
PrestaShop English User Documentation
Prestashop Shop Creator tool
- #5: Add composer 2 compatibility and use new faker lib. Thank you @davidglezz
Where to start contributing?
What about fixing a label incorrectly displayed in the Back Office Create an order page ? This is a bug report submitted last month, and it is one of our good first issues.
Good first issues are a list of all beginner-friendly improvements and bugs to fix in the project. You can read more about this label on our article about it.
Thank you to the contributors whose pull requests were merged since the last Core Weekly Report: @Progi1984, @NeOMakinG, @matks, @PierreRambaud, @nenes25, @boubkerbribri, @dependabot, @nesrineabdmouleh, @kpodemski, @agostinofiscale, @marionf, @Quetzacoalt91, @Julievrz, @zuk3975, @sowbiba, @davidglezz, @matthieu-rolland, @JevgenijVisockij, @ks129!
Thank you to the contributors whose PRs haven’t been merged yet! And of course, a big thank you to all those who contribute with issues and comments on GitHub!
If you want to contribute to PrestaShop with code, please read these pages first:
…and if you do not know how to fix an issue but wish to report it, please read this: How to use GitHub to report an issue. Thank you!
Happy contributin’ everyone!
This post is also available in: English